Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacking screen #64

Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add stacking screen #64

merged 5 commits into from
Nov 21, 2022

Conversation

Imamah-Zafar
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

@Imamah-Zafar Imamah-Zafar self-assigned this Nov 15, 2022
@Imamah-Zafar Imamah-Zafar linked an issue Nov 15, 2022 that may be closed by this pull request
@yknl
Copy link
Contributor

yknl commented Nov 16, 2022

I might be doing something wrong but opening the stacking tab gives an infinite loading screen right now.

This is a newly created wallet without anything in it.

image

@DuskaT021 DuskaT021 added the enhancement New feature or request label Nov 16, 2022
@DuskaT021 DuskaT021 added this to the Sprint 21 - Nov 28 milestone Nov 16, 2022
@Imamah-Zafar
Copy link
Contributor Author

I might be doing something wrong but opening the stacking tab gives an infinite loading screen right now.

This is a newly created wallet without anything in it.

image

this is because the current core library does not have api calls needed for getting the stacking info. the api calls are added in this pr .
https://github.com/secretkeylabs/xverse-core/pull/15/files

@Imamah-Zafar Imamah-Zafar merged commit a715a73 into develop Nov 21, 2022
@victorkirov victorkirov deleted the imamahzafar/feat/stacking branch November 9, 2023 12:26
teebszet pushed a commit that referenced this pull request Nov 29, 2023
* feat: tweak rare sats bundle screen to support new satributes

* feat: add v2 of useGetUtxoOrdinalBundle and use it in ordinal detail screen

* feat: ordinal bundle in confirm screen

* fix: add missing ordinal number

---------

Co-authored-by: fede erbes <fedeerbes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs - Stacking
3 participants