-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mahmoud/eng 3111 integrate with stacks raw hex signing on extension #652
Merged
m-aboelenein
merged 22 commits into
develop
from
mahmoud/eng-3111-integrate-with-stacks-raw-hex-signing-on-extension
Dec 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
d3d7da9
init tx hex handling
m-aboelenein 9a299ef
Merge branch 'develop' into mahmoud/eng-3111-integrate-with-stacks-raβ¦
m-aboelenein 3c4dbce
added stx hex tx signing support
m-aboelenein ce32d7b
Merge branch 'develop' into mahmoud/eng-3111-integrate-with-stacks-raβ¦
m-aboelenein 257853a
integrate with connect core utils
m-aboelenein c236db2
fix stx tx serialization
m-aboelenein 7d7ec42
handle sign-hex for dapp interactions
m-aboelenein 18051f4
update core version
m-aboelenein 308588b
add auh to tx-creation
m-aboelenein 2250045
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-iβ¦
m-aboelenein 4fcd9f6
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-iβ¦
m-aboelenein d596b0d
Merge remote-tracking branch 'refs/remotes/origin/develop'
m-aboelenein 156fd64
fix pending txs handling
m-aboelenein a5103b2
fix type issues
m-aboelenein 4171497
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-iβ¦
m-aboelenein fef354f
update core version
m-aboelenein 0d0a5c4
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-iβ¦
m-aboelenein d3d8657
revert removing signMultipleTransactions
m-aboelenein 38b5a92
update core version
m-aboelenein 06b05aa
Merge remote-tracking branch 'origin/develop' into mahmoud/eng-3111-iβ¦
m-aboelenein 5e33c8d
remove unused package aliases
m-aboelenein 45d9f63
Tim/eng 3475 nonce not updating correctly after switching accounts (#β¦
teebszet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious what was the reasoning for Partial here? π
do we want to hide type errors when we forget to add a new method from sats-connect? π€
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my case, the version of sats-connect that we had in
package.json
was ahead of what was merged indevelop
at the time we might not want to keep it though, it's necessary now so the build doesn't failThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see. I'd be keen to remove it before merge, since it was a good code hint before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-aboelenein did you have a chance to follow up on this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch i reverted that change π