Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when clicking on the inscription image in the details view #659

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Nov 14, 2023

πŸ”˜ PR Type

  • Bugfix
  • Code style update (formatting, local variables)

πŸ“œ Background

issue: https://linear.app/xverseapp/issue/ENG-3213/when-clicking-on-the-inscription-image-in-the-details-view

πŸ”„ Changes

  • fix: remove the preview option from rc-image component in ordinals detail
  • fix: height was slightly off on ordinal image in detail screen
  • fix: details items in two columns were not centrally aligned
  • chore: some eslint warnings and type warnings

Impact:

  • can check anywhere an ordinal image is displayed

πŸ–Ό Screenshot / πŸ“Ή Video

before:
image
image

after:
image
image

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@teebszet teebszet changed the title Tim/eng 3213 when clicking on the inscription image in the details view fix: when clicking on the inscription image in the details view Nov 14, 2023
@teebszet teebszet merged commit 4d1d1e4 into develop Nov 14, 2023
2 checks passed
teebszet added a commit that referenced this pull request Nov 14, 2023
@teebszet
Copy link
Member Author

teebszet commented Nov 14, 2023

@DuskaT021 oops sorry I got trigger happy and merged this. let me know if it needs a fix after testing

@teebszet teebszet mentioned this pull request Nov 21, 2023
1 task
@teebszet teebszet deleted the tim/eng-3213-when-clicking-on-the-inscription-image-in-the-details-view branch November 23, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants