Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fiat rates not fetching when user changed currency #669

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Nov 21, 2023

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

https://secretkeylabs.slack.com/archives/C05QCJM9D1N/p1700550855171529

πŸ”„ Changes

  • fix: use correct cache keys where staleTime was introduced, but previously cache keys were too broad

Impact:

  • also made sure other changed queries in the same commit have enough params in their query cache keys (it could have resulted in bugs where data was cached between switching testnet/mainnet, but would have been very rare because you the other queries were still caching by id as well)

πŸ–Ό Screenshot / πŸ“Ή Video

Screen.Recording.2023-11-21.at.3.48.03.PM.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@teebszet teebszet changed the title fix: cache keys for react queries where stale time was added fix: fiat rates not fetching when user changed currency Nov 21, 2023
Copy link
Contributor

@jordankzf jordankzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works well. The fiat amount now updates instantly.

@DuskaT021
Copy link
Contributor

tested we can merge @teebszet

@teebszet teebszet merged commit f6c4ece into develop Nov 21, 2023
2 checks passed
@teebszet teebszet deleted the fix-coin-rate-cache-keys branch November 21, 2023 10:30
@teebszet teebszet mentioned this pull request Nov 21, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants