Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot/fix - migration for legacy users #675

Conversation

m-aboelenein
Copy link
Member

@m-aboelenein m-aboelenein commented Nov 23, 2023

🔘 PR Type

What kind of change does this PR introduce?

  • remove automatic migration for local storage
  • show warning for legacy users to reset their wallet

Versions affected: < 0.11.6

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

local storage migration was failing for legacy users due to compatibility issues with the new security architecture

Issue Link: #ENG-3316]

Impact:

  • legacy users will need to reset their wallet in-order to complete the migration

🖼 Screenshot / 📹 Video

Screenshot 2023-11-23 at 10 52 29 AM

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@teebszet
Copy link
Member

@DuskaT021 approved from slack

@teebszet teebszet merged commit d39b9be into develop Nov 24, 2023
2 checks passed
@teebszet teebszet deleted the mahmoud/eng-3316-unable-to-see-seed-phrase-when-migrating-from-very-old branch November 24, 2023 04:04
This was referenced Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants