Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3307] fix: use isInitialLoading so skeleton loader shows only if query is e… #680

Conversation

teebszet
Copy link
Member

…nabled

🔘 PR Type

  • Bugfix

📜 Background

https://linear.app/xverseapp/issue/ENG-3307/for-ledger-users-who-havent-activated-stx-yet-they-see-a-skeleton

🔄 Changes

  • fix: should use isInitialLoading to display skeleton loader only if query is loading and fetching first time (not disabled)

Impact:

  • nfts tab and inscriptions tab only

🖼 Screenshot / 📹 Video

image

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link

@DuskaT021
Copy link
Contributor

@teebszet tested 👍

@teebszet teebszet merged commit 326bbbd into develop Nov 29, 2023
2 checks passed
@teebszet teebszet deleted the tim/eng-3307-for-ledger-users-who-havent-activated-stx-yet-they-see-a branch November 29, 2023 09:04
@teebszet teebszet changed the title fix: use isInitialLoading so skeleton loader shows only if query is e… [ENG-3307] fix: use isInitialLoading so skeleton loader shows only if query is e… Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants