Home dashboard UI fix #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Nov 17, 2022
|
Minor issue but what should we do with the scroll bar? @QUDBS
|
yknl
reviewed
Nov 23, 2022
src/app/screens/home/index.tsx
Outdated
| } = useSelector((state: StoreState) => state.walletState); | ||
|
|
||
| const fetchFeeMultiplierData = async () => { | ||
| const response: FeesMultipliers = await fetchAppInfo(); | ||
| dispatch(FetchFeeMultiplierAction(response)); | ||
| }; | ||
|
|
||
| const getActiveAccountList = async ( |
There was a problem hiding this comment.
Should this logic be in the core library since it's used in both the app and the extension. It's also quite isolated.
yknl
reviewed
Nov 23, 2022
| @@ -8,6 +8,8 @@ import { useNavigate } from 'react-router-dom'; | |||
| import { Ring } from 'react-spinners-css'; | |||
| import useWalletReducer from '@hooks/useWalletReducer'; | |||
|
|
|||
| declare const VERSION: string; | |||
There was a problem hiding this comment.
how is this version string set?
There was a problem hiding this comment.
in the webpack.config.js the version variable is set and can be accessed anywhere in the app to avoid hardcoding the extension version number
yknl
reviewed
Nov 23, 2022
src/app/utils/helper.ts
Outdated
| @@ -75,3 +76,22 @@ export async function isValidURL(str: string): Promise<boolean> { | |||
| } | |||
| return false; | |||
| } | |||
|
|
|||
| export async function checkAccountActivity( | |||
There was a problem hiding this comment.
This should probably also be in the core library.
…-extension into imamahzafar/home-dashboard-ui-fix
yknl
approved these changes
Nov 24, 2022
teebszet
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix: spacing issues * added scrollbar in rare sat detail * fix: scrollbar in confirm screen * fix: scrollbar in rarity screen * fix: send errors * removed console log * fix: rare sat bundle navigation * fix: rare detail text * fix: confirm UI * fix: rare sats bundle navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Fixes ui bugs found in the main dashboard screen
loads all active accounts when user logs in
fixes bug in account screen