feat: add hook for confirmed btc balance, inscription callouts #711
Conversation
There was a problem hiding this comment.
Good job @abdulhaseeb4239! 🙌
Not a blocker, but I left a couple of suggestions below 😋
|
|
||
| const fetchBtcAddressData = async () => btcClient.getAddressData(btcAddress); | ||
|
|
||
| let confirmedBalance: number = 0; |
There was a problem hiding this comment.
| let confirmedBalance: number = 0; | |
| let confirmedBalance = 0; |
There was a problem hiding this comment.
nit: do we need to explicitly set the type here? I think we can rely on type inference here https://www.typescriptlang.org/docs/handbook/type-inference.html
src/locales/en.json
Outdated
| @@ -982,7 +982,9 @@ | |||
| "FAILED_TO_FINALIZE": "The inscription transaction failed to finalize. Please try again or contact support.", | |||
| "SERVER_ERROR": "An unknown server error occurred. Please try again or contact support." | |||
| }, | |||
| "TOO_MANY_REPEATS": "You can only create up to 24 inscriptions in a single request" | |||
| "TOO_MANY_REPEATS": "You can only create up to 24 inscriptions in a single request", | |||
There was a problem hiding this comment.
I think it would be good to move the 24 number to some constant (in a shared file or the component where it's used) to not change the translations in case the number needs to be changed, right? We can then pass it like this:
There was a problem hiding this comment.
That's a valid point. Although this wasn't included in the current pull request, I've addressed it anyway 😄
|
@dhriaznov could you also make sure to maually test this PR and mark when tested, since @DuskaT021 won't be back until two more days |
@teebszet I'll pick it up today 🙂 |
|
@abdulhaseeb4239 could you resolve the conflicts pls? |
resolved |
|
A heads-up that the build just failed @abdulhaseeb4239 |
package-lock.json
Outdated
There was a problem hiding this comment.
@abdulhaseeb4239 we should revert the package-lock.json changes as they're not needed and they also cause the build failure in this PR
|
🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Xverse currently displays unconfirmed UTXOs as part of users' balance. This can lead to failed transaction attempts if users try to inscribe, thinking that they have sufficient funds, while some of their balance consists of unconfirmed UTXOs.
Issue Link:
ENG-3385
ENG-3416
🔄 Changes
This PR depends on unreleased version from xverse-core PR
Impact:
🖼 Screenshot / 📹 Video
✅ Review checklist
Please ensure the following are true before merging: