Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-3325] chore: refactor workflows #714

Merged
merged 16 commits into from
Jan 2, 2024
Merged

Conversation

teebszet
Copy link
Member

@teebszet teebszet commented Dec 15, 2023

馃敇 PR Type

  • CI related changes

馃摐 Background

https://www.notion.so/xverseapp/Xverse-Web-Extension-Release-Instructions-f850e51a4a9f4eba94b9ad27eb8beca6

automating steps 6-8

https://linear.app/xverseapp/issue/ENG-3325

馃攧 Changes

  • required some refactoring of the workflows
    • refactor build.yaml to:
      • trigger only for PRs not named like a release PR
    • create a build-rc.yaml for release PRs to:
      • trigger on pull_request events to main & develop named like a release PR
      • create the release (moved from create-release-pr.yml)
      • build and upload the release asset (moved from release.yml)
    • refactor release.yaml to:
      • trigger on merge of release PR to main
      • look for the latest release candidate and create the 'latest' release with the same target_comittish

Copy link

@teebszet teebszet marked this pull request as ready for review December 18, 2023 04:28
@teebszet teebszet changed the title chore: refactor workflows [ENG-3325] chore: refactor workflows Dec 18, 2023
Copy link
Contributor

@dhriaznov dhriaznov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@teebszet teebszet merged commit 74394d3 into develop Jan 2, 2024
3 checks passed
@teebszet teebszet deleted the chore/refactor-workflows branch January 2, 2024 08:27
This was referenced Jan 11, 2024
@teebszet teebszet restored the chore/refactor-workflows branch January 11, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants