ENG-3402 Named classes for styled-components #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordankzf
force-pushed
the
jordankzf/named-styled-component-classes
branch
from
7000040
to
dba58e3
Compare
jordankzf
force-pushed
the
jordankzf/named-styled-component-classes
branch
from
dba58e3
to
5c1f4f2
Compare
jordankzf
requested review from
teebszet,
victorkirov and
m-aboelenein
and removed request for
teebszet and
victorkirov
teebszet
reviewed
Jan 4, 2024
webpack/webpack.config.js
Outdated
Comment on lines
73
to
76
| // before: [ | ||
| // env.NODE_ENV === 'development' && ReactRefreshTypeScript(), | ||
| // env.NODE_ENV === 'development' && styledComponentsTransformer, | ||
| // ].filter(Boolean), |
There was a problem hiding this comment.
can remove these commented out lines
teebszet
previously approved these changes
Jan 4, 2024
jordankzf
commented
Jan 4, 2024
|
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7405190646 |
teebszet
approved these changes
Jan 4, 2024
This was referenced Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker
Mismatched peer dependencies🔘 PR Type
What kind of change does this PR introduce?
📜 Background
Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.
Issue Link: ENG-3402
Context Link (if applicable):
🔄 Changes
Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.
Impact:
🖼 Screenshot / 📹 Video
Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.
✅ Review checklist
Please ensure the following are true before merging: