Tim/eng 3475 nonce not updating correctly after switching accounts #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
m-aboelenein
approved these changes
Dec 20, 2023
|
I see some request looping. not ready for merge |
m-aboelenein
changed the base branch from
develop
to
mahmoud/eng-3111-integrate-with-stacks-raw-hex-signing-on-extension
m-aboelenein
force-pushed
the
tim/eng-3475-nonce-not-updating-correctly-after-switching-accounts
branch
from
62932b0
to
3e83755
Compare
…on-extension' into tim/eng-3475-nonce-not-updating-correctly-after-switching-accounts
dhriaznov
approved these changes
Dec 27, 2023
m-aboelenein
merged commit 45d9f63
into
mahmoud/eng-3111-integrate-with-stacks-raw-hex-signing-on-extension
m-aboelenein
deleted the
tim/eng-3475-nonce-not-updating-correctly-after-switching-accounts
branch
m-aboelenein
added a commit
that referenced
this pull request
Dec 27, 2023
…652) * init tx hex handling * added stx hex tx signing support * integrate with connect core utils * fix stx tx serialization * handle sign-hex for dapp interactions * update core version * add auh to tx-creation * fix pending txs handling * fix type issues * update core version * revert removing signMultipleTransactions * update core version * remove unused package aliases * Tim/eng 3475 nonce not updating correctly after switching accounts (#725) * fix: regenerate the unsignedTx with correct stxAddress after switch account * fix: minor cleanup * fix tx-request account switching * updated core version * added type checking and default values for feeMultipliers --------- Co-authored-by: Mahmoud Aboelenein <mahmoud@secretkeylabs.com> --------- Co-authored-by: Tim Man <tim@secretkeylabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔘 PR Type
📜 Background
Issue Link: https://linear.app/xverseapp/issue/ENG-3475
there is a feature on the transaction request screen which checks a dapp tx request popup payload and does an auto account switch if there is a mismatch.
scenario 1:
if I signed in with account 1 on the dapp, and switched my extension to account 2,
expect the popup for a dapp tx will auto switch my account back to the one matching what I signed into the dapp with.
🔄 Changes
this fix doesn't change the behaviour, but ensures the auto switch also regenerates the unsignedTx with the correct account (and therefore displays the correct nonce in Edit Nonce)
Impact:
🖼 Screenshot / 📹 Video
after fix:
trimmed.mov
also tested with pending transactions, and nonce increments as expected
✅ Review checklist
Please ensure the following are true before merging: