Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new png and svg icons for satributes #730

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat: add new png and svg icons for satributes #730

merged 1 commit into from
Dec 29, 2023

Conversation

fedeerbes
Copy link
Contributor

🔘 PR Type

  • Enhancement

📜 Background

This PR adds .png and .svg extension to support the correct icons with the right storage size

Issue Link: #ENG-3356

🔄 Changes

  • add new files for .png and .svg icons

🖼 Screenshot / 📹 Video

Screen.Recording.2023-12-29.at.11.38.08.mov

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@fedeerbes fedeerbes self-assigned this Dec 29, 2023
@github-actions GitHub Actions
Copy link

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7356311681

@DuskaT021 DuskaT021 added testing QA testing in progress and removed ready for test labels Dec 29, 2023
@fedeerbes fedeerbes removed the testing QA testing in progress label Dec 29, 2023
@fedeerbes fedeerbes merged commit cace084 into develop Dec 29, 2023
2 checks passed
This was referenced Dec 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdulhaseeb4239 abdulhaseeb4239 abdulhaseeb4239 approved these changes

@dhriaznov dhriaznov dhriaznov approved these changes

Assignees

@fedeerbes fedeerbes

Labels
ready for release Release 0.27.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fedeerbes @abdulhaseeb4239 @dhriaznov @DuskaT021