-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-3496] fix: utxo 500 issue add a fallback option to our api httpsbtc #738
[ENG-3496] fix: utxo 500 issue add a fallback option to our api httpsbtc #738
Conversation
β¦txo-500-issue-add-a-fallback-option-to-our-api-httpsbtc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a thread of comments but maybe the idea is to not use the URL value from the config endpoint? If that's the case, then I'm happy to approve π
I asked @m-aboelenein here: https://secretkeylabs.slack.com/archives/C05QCJM9D1N/p1704804634811279 and looks like we can remove that functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much cleaner! π
@teebszet needs conflicts resolved |
β¦lback-option-to-our-api-httpsbtc
@DuskaT021 done! |
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7475252053 |
π PR Type
π Background
Issue Link: ENG-3496
depends on: secretkeylabs/xverse-core#339
π Changes
Impact:
πΌ Screenshot / πΉ Video
Screen.Recording.2024-01-09.at.6.58.36.PM.mov
β Review checklist
Please ensure the following are true before merging: