Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[END 3565] fix: catch and display failed to broadcast error #751

Conversation

teebszet
Copy link
Member

πŸ”˜ PR Type

  • Bugfix

πŸ“œ Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: #[issue_number]
Context Link (if applicable):

πŸ”„ Changes

  • add an error message for when stacks speed up fails to sign and broadcast
  • updated the error message to remove the 'microblock' part
  • fix styling of error toasts

πŸ–Ό Screenshot / πŸ“Ή Video

image

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Copy link
Contributor

@DuskaT021 DuskaT021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@teebszet teebszet merged commit cd7c798 into release/v0.28.0 Jan 12, 2024
@teebszet teebszet deleted the tim/eng-3565-speed-up-was-broken-for-ken-on-httpssordinalscominscribe branch February 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants