-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send btc integrate with tx consolidation logic #766
Merged
teebszet
merged 54 commits into
develop
from
victor/eng-3548-ext-send-btc-integrate-tx-consolidation-logic-tx
Feb 15, 2024
Merged
Send btc integrate with tx consolidation logic #766
teebszet
merged 54 commits into
develop
from
victor/eng-3548-ext-send-btc-integrate-tx-consolidation-logic-tx
Feb 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦-consolidation-logic-tx
jordankzf
reviewed
Jan 23, 2024
jordankzf
reviewed
Jan 23, 2024
Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>
Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>
β¦-consolidation-logic-tx
fyi ledger happy path passed with flying colours π |
teebszet
previously approved these changes
Feb 2, 2024
β¦-extension into victor/eng-3548-ext-send-btc-integrate-tx-consolidation-logic-tx
DuskaT021
previously approved these changes
Feb 13, 2024
teebszet
previously approved these changes
Feb 14, 2024
teebszet
approved these changes
Feb 15, 2024
Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7913360440 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: depends on secretkeylabs/xverse-core#346
π PR Type
What kind of change does this PR introduce?
π Background
This introduces the use of the new txn logic for the send btc screen. Additionally it adds the send max functionality.
π Changes
The send btc screen was rewritten to use the new txn logic.
Impact:
πΌ Screenshot / πΉ Video
Screen.Recording.2024-01-19.at.11.05.50.mov
β Review checklist
Please ensure the following are true before merging: