Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send btc integrate with tx consolidation logic #766

Conversation

victorkirov
Copy link
Member

@victorkirov victorkirov commented Jan 18, 2024

NOTE: depends on secretkeylabs/xverse-core#346

πŸ”˜ PR Type

What kind of change does this PR introduce?

  • Enhancement

πŸ“œ Background

This introduces the use of the new txn logic for the send btc screen. Additionally it adds the send max functionality.

πŸ”„ Changes

The send btc screen was rewritten to use the new txn logic.

Impact:

  • The send btc screen has been completely rewritten for the software and ledger wallets
  • The txn confirmation screen now uses the same component as the sign PSBT screen. The component has slight changes, so that screen also needs a test.
  • The spinner from zero height was implemented and replaces the previous spinner we used throughout the app

πŸ–Ό Screenshot / πŸ“Ή Video

Screen.Recording.2024-01-19.at.11.05.50.mov

βœ… Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@victorkirov victorkirov self-assigned this Jan 18, 2024
@victorkirov victorkirov marked this pull request as ready for review January 19, 2024 09:09
victorkirov and others added 4 commits January 23, 2024 08:58
Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>
Co-authored-by: Jordan K. <65149726+jordankzf@users.noreply.github.com>
@teebszet
Copy link
Member

teebszet commented Feb 2, 2024

fyi ledger happy path passed with flying colours πŸŽ‰

teebszet
teebszet previously approved these changes Feb 2, 2024
@DuskaT021 DuskaT021 added returned Tested by the QA, didn't pass checks and removed ready for test labels Feb 12, 2024
DuskaT021
DuskaT021 previously approved these changes Feb 13, 2024
teebszet
teebszet previously approved these changes Feb 14, 2024
@teebszet teebszet added ready for release and removed returned Tested by the QA, didn't pass checks labels Feb 14, 2024
@teebszet teebszet dismissed stale reviews from DuskaT021 and themself via 804d050 February 15, 2024 08:56
Copy link

@teebszet teebszet merged commit d9b1432 into develop Feb 15, 2024
5 checks passed
@teebszet teebszet deleted the victor/eng-3548-ext-send-btc-integrate-tx-consolidation-logic-tx branch February 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants