Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide rare sats warning #827

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

jordankzf
Copy link
Contributor

@jordankzf jordankzf commented Jun 13, 2024

🔘 PR Type

What kind of change does this PR introduce?
image

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

📜 Background

Provide a brief explanation of why this pull request is needed. Include the problem you are solving or the functionality you are adding. Reference any related issues.

Issue Link: ENG-4466
Context Link (if applicable): https://linear.app/xverseapp/issue/ENG-4466/%F0%9F%A6%8B%E2%9A%A0%EF%B8%8F-user-confused-about-rare-sats-in-payment-address-callout#comment-d6b3873a

🔄 Changes

Enumerate the changes made in this pull request, detailing what has been modified, added, or removed. Include technical details and implications if necessary.

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.

🖼 Screenshot / 📹 Video

Include screenshots or a video demonstrating the changes. This is especially helpful for UI changes.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@jordankzf jordankzf requested a review from a team as a code owner June 13, 2024 12:17
@jordankzf jordankzf requested a review from aryzing June 13, 2024 12:17
@jordankzf jordankzf merged commit 841ee0d into develop Jun 14, 2024
9 of 10 checks passed
@jordankzf jordankzf deleted the jordankzf/remove-rare-sats-warning branch June 14, 2024 07:03
@teebszet teebszet restored the jordankzf/remove-rare-sats-warning branch June 20, 2024 04:38
@teebszet teebszet deleted the jordankzf/remove-rare-sats-warning branch June 20, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants