-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Publish secretlint package and Docker Image from CI #68
Comments
We have introduce changesets as release flow |
changesets is work, but it does not integrate lerna's conventional-commits. |
I've written Release Flow idea. |
conventional-commits is not frindly for new contirbutors. In the future, we can use Conventional Commit based versioning and GitHub PR's labels based version. |
I've filed to ship.js algolia/shipjs#713 |
I've created simple lerna workflow example |
Finally We have replaced changesets with lerna +GitHub Action |
Current Problem: We must build docker image after publishing npm package.
Because,
Dockerfile
install the published version from npm reigstry.secretlint/docker/Dockerfile
Line 11 in d127d23
Dependencies illust:
So, We can not use
lerna version
with --create-release option.The reason of adding
--no-push
option .secretlint/package.json
Lines 30 to 33 in 8723133
We want to resolve this by publishing to npm from CI.
In Local
npm run versionup
In CI
npm run release
iftags
is pushedThe text was updated successfully, but these errors were encountered: