Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Publish secretlint package and Docker Image from CI #68

Closed
azu opened this issue Mar 1, 2020 · 8 comments
Closed

CI: Publish secretlint package and Docker Image from CI #68

azu opened this issue Mar 1, 2020 · 8 comments
Labels
Type: CI Changes to CI configuration files and scripts

Comments

@azu
Copy link
Member

azu commented Mar 1, 2020

Current Problem: We must build docker image after publishing npm package.
Because, Dockerfile install the published version from npm reigstry.

RUN npm install -g secretlint@${SECRETLINT_VERSION} @secretlint/secretlint-rule-preset-recommend@${SECRETLINT_VERSION} && \

Dependencies illust:

publish to npm -> build Docker Image that install secretlint from npm

So, We can not use lerna version with --create-release option.

The reason of adding --no-push option .

secretlint/package.json

Lines 30 to 33 in 8723133

"versionup": "lerna version --no-push --conventional-commits",
"versionup:patch": "lerna version patch --no-push --conventional-commits",
"versionup:minor": "lerna version minor --no-push --conventional-commits",
"versionup:major": "lerna version major --no-push --conventional-commits",

We want to resolve this by publishing to npm from CI.

In Local

  • npm run versionup

In CI

  • npm run release if tags is pushed
@azu azu added the Type: CI Changes to CI configuration files and scripts label Mar 1, 2020
@azu
Copy link
Member Author

azu commented Mar 1, 2020

@azu
Copy link
Member Author

azu commented Mar 1, 2020

changesets is work, but it does not integrate lerna's conventional-commits.

@azu
Copy link
Member Author

azu commented Mar 7, 2020

I've written Release Flow idea.

@azu
Copy link
Member Author

azu commented Mar 7, 2020

conventional-commits is not frindly for new contirbutors.
We want to get GitHub's label based versioning as another options.

In the future, we can use Conventional Commit based versioning and GitHub PR's labels based version.
Both can be coexist.

@azu
Copy link
Member Author

azu commented Mar 7, 2020

I've filed to ship.js algolia/shipjs#713

@azu azu changed the title CI: Publish from CI CI: Publish secretlint package and Docker Image from CI Mar 7, 2020
@azu
Copy link
Member Author

azu commented Mar 11, 2020

I've created simple lerna workflow example
https://github.com/azu/lerna-monorepo-github-actions-release

@azu
Copy link
Member Author

azu commented Mar 16, 2020

Finally We have replaced changesets with lerna +GitHub Action
https://github.com/secretlint/secretlint/blob/master/CONTRIBUTING.md#release-flow

@azu azu closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Changes to CI configuration files and scripts
Projects
None yet
Development

No branches or pull requests

1 participant