Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TLS for active connections #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

drakkan
Copy link

@drakkan drakkan commented Sep 16, 2020

based on RFC 4217, section 7, for active connections the FTP client MUST
be the TLS client and the FTP server MUST be the TLS server

based on RFC 4217, section 7, for active connections the FTP client MUST
be the TLS client and the FTP server MUST be the TLS server
@drakkan
Copy link
Author

drakkan commented Sep 16, 2020

After fixing the proftpd link travis test pass again. I tryed to update to the latest pure-ftpd and proftpd versions but with new versions these tests fails:

=== RUN   TestExplicitTLS
    client_test.go:60: error reading response: EOF
--- FAIL: TestExplicitTLS (0.03s)
=== RUN   TestImplicitTLS
    client_test.go:97: error reading response: EOF

no time to investigate further sorry

drakkan added a commit to drakkan/ftpserverlib that referenced this pull request Sep 16, 2020
We need this patch:

secsy/goftp#52

to run test cases.

Fixes fclairamb#177
fclairamb pushed a commit to fclairamb/ftpserverlib that referenced this pull request Sep 16, 2020
We need this patch:

secsy/goftp#52

to run test cases.

Fixes #177
@jtwatson jtwatson mentioned this pull request Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant