Allow CMS pages to not be banned in Varnish when products are updated #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new option to the Full Page Cache configuration section in Stores configuration "Include CMS Pages in product purges". If set to No, CMS pages will not be purged when a product is updated, even if that product is displayed on the page. CMS pages will still be purged if their content is updated.
glennslaven
force-pushed
the
includeCmsInProductPurge
branch
from
de671c7
to
aa96007
Compare
Model/PurgeCache.php
Outdated
| ]); | ||
|
|
||
| $info = $this->aperture->executeAuthRequest($uri, 'POST', [], self::BAN_TIMEOUT_SECONDS); | ||
| if ($info['http_code'] != 200) { | ||
| $this->logger->execute('Error executing purge: ' . $tagsPattern.', Error: ' . $info['body_content']); | ||
| return false; | ||
| } | ||
| $this->logger->execute(compact('server', 'tagsPattern')); | ||
| //$this->logger->execute(compact('server', 'tagsPattern')); |
calvinbrewer
approved these changes
Jun 26, 2018
calvinbrewer
approved these changes
Jun 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option to the Full Page Cache configuration section in Stores
configuration "Include CMS Pages in product purges". If set to No, CMS
pages will not be purged when a product is updated, even if that product
is displayed on the page. CMS pages will still be purged if their content
is updated.