Set the AreaCode for the app state created by the ObjectManager #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magento Commerce 2.2.3 was throwing errors due to the AreaCode not being set when the SidResolver called into app state to get the area code. The app state object being inserted by the DI system is null and the instance created by the ObjectManager is a different instance to the one we get injected into our SetupCommand class. See https://github.com/magento/magento2/blob/2.2.3/lib/internal/Magento/Framework/Session/SidResolver.php#L85
jstangroome
approved these changes
May 29, 2018
ivan-section-io
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magento Commerce 2.2.3 was throwing errors due to the AreaCode not being set when the SidResolver called into app state to get the area code.
The app state object being inserted by the DI system is null and the instance created by the ObjectManager is a different instance to the one we get injected into our SetupCommand class.
See https://github.com/magento/magento2/blob/2.2.3/lib/internal/Magento/Framework/Session/SidResolver.php#L85