Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround installation issue #532

Merged
merged 7 commits into from
Nov 25, 2022
Merged

Conversation

fabianbs96
Copy link
Member

As #531 shows, there are issues with the installation of phasar. This PR aims to work around this issue to bridge the time until #516 is merged.

@fabianbs96
Copy link
Member Author

Note: In this PR the examples/use-phasar-as-library folder is still out-of-sync with rest of phasar. This is already fixed in #530, so I won't fix it here again

@pdschubert
Copy link
Member

I'm probably not a good candidate to review this. @MMory and @vulder will be much better reviewers for the pull-request. Let me know if I can safely merge these changes.

Copy link
Collaborator

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what I can judge, LGTM overall

@fabianbs96 fabianbs96 merged commit 9c39fd8 into development Nov 25, 2022
@fabianbs96 fabianbs96 deleted the f-WorkaroundInstallationIssue branch November 25, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants