Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify verification on multiple signatures in a envelope #41

Closed
wants to merge 4 commits into from
Closed

Clarify verification on multiple signatures in a envelope #41

wants to merge 4 commits into from

Conversation

shizhMSFT
Copy link
Contributor

Resolves #40

@shizhMSFT
Clarify verification on multiple signatures
e8787b8 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT mentioned this pull request Jul 14, 2021
Closed
@trishankatdatadog
Copy link
Collaborator

Maybe add a bit more text please. You could mention TUF or in-toto as applications which use threshold signatures, where m out of n signatures must be valid for the application to accept the payload.

@shizhMSFT
add examples
99e8b8d 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT
reword
7b3fd54 
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
trishankatdatadog
trishankatdatadog reviewed Jul 16, 2021
View reviewed changes
envelope.md Outdated Show resolved Hide resolved
@trishankatdatadog
Copy link
Collaborator

@MarkLodato @SantiagoTorres LGTY?

MarkLodato
MarkLodato approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@MarkLodato MarkLodato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an improvement, but IMO it is is not sufficient to resolve #40. In addition, I think we need an update to protocol.md to explain how the verifier should handle multiple signatures. I'll continue discussion in #40.

@adityasaky
Copy link
Member

Closing this since #45 has been accepted.

@adityasaky adityasaky closed this Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLodato MarkLodato MarkLodato approved these changes

@trishankatdatadog trishankatdatadog trishankatdatadog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to verify an envelope properly?
4 participants
@shizhMSFT @trishankatdatadog @adityasaky @MarkLodato