Add signerverifiers for RSAPSS, ECDSA, ED25519 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish <aditya@saky.in>
Pull Request Test Coverage Report for Build 4853551288
💛 - Coveralls |
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish <aditya@saky.in>
Signed-off-by: Aditya Sirish <aditya@saky.in>
pxp928
reviewed
May 1, 2023
* Address review comments from @pxp928 * Add docstrings * Add credits for code from in-toto-golang * Check if KeyVal is missing when creating signerverifiers * Make KeyID public and calculate key ID while loading only if it's missing Signed-off-by: Aditya Sirish <aditya@saky.in>
adityasaky
force-pushed
the
add-signers
branch
3 times, most recently
from
13d3e0d
to
7c1bd7e
Compare
* Add tests verifying Metablock signatures * Fix RSA key load with trailing newline Signed-off-by: Aditya Sirish <aditya@saky.in>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates DSSE friendly signerverifiers for the these key types, with some of the logic inspired by in-toto-golang's keylib. The idea is to move this in here and use it for Metablock and DSSE in in-toto-golang going forward.