Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version management description #11

Merged

Conversation

mnm678
Copy link
Collaborator

@mnm678 mnm678 commented Oct 10, 2019

Added a section near the end of the PEP to briefly describe and link to the TAP for version management in TUF. Note that the link is to the pr in the TAP repo and will need to be updated after the pr is merged.

Copy link

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the places where you added blank lines. Also address the text at the bottom to make it clearer in terms of what is being requested of the implementer.

pep-0458.txt Outdated

If breaking changes are made to the update process, PyPI should implement these
changes without disrupting existing clients. To do so, PyPI should maintain
previous versions of metadata so that clients can access the version of metadata

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too vague. We don't have enough specifics now. My feeling is it should be written in a less ambiguous way (referring to look at the TAP for data storage), even if it says less here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

pep-0458.txt Outdated

If breaking changes are made to the update process, PyPI should implement these
changes without disrupting existing clients. To do so, PyPI should maintain
previous versions of metadata so that clients can access the version of metadata
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@trishankatdatadog trishankatdatadog merged commit 0c20efe into secure-systems-lab:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants