Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove python2 shebang in hash module #498

Closed
lukpueh opened this issue Jan 31, 2023 · 0 comments · Fixed by #544
Closed

remove python2 shebang in hash module #498

lukpueh opened this issue Jan 31, 2023 · 0 comments · Fixed by #544
Labels
bug help wanted

Comments

@lukpueh
Copy link
Member

lukpueh commented Jan 31, 2023

Description of issue or feature request:
securesystemslib/hash.py has a python2 shebang line, which is obsolete (Py2 support was dropped a while ago) and wrong (no need run the module by itself).

Current behavior:

securesystemslib/securesystemslib/hash.py

Line 1 in 416dab2

#!/usr/bin/env python2

Expected behavior:
No shebang line.

Bonus task:

Review eligibility of shebang lines in other modules too.
@jku jku mentioned this issue Mar 20, 2023
Closed
ckilcoin pushed a commit to ckilcoin/securesystemslib that referenced this issue Mar 21, 2023
Remove shebang line from hash.py secure-systems-lab#498
139469b 
Python2 support has been dropped and we do not need to run the
module by itself.
@ckilcoin ckilcoin mentioned this issue Mar 21, 2023
Merged
3 tasks
mnm678 added a commit that referenced this issue Mar 21, 2023
@mnm678
Merge pull request #544 from ckilcoin/colm-development
5c4f934 
Remove shebang line from hash.py #498
ckilcoin pushed a commit to ckilcoin/securesystemslib that referenced this issue Mar 21, 2023
Remove all python shebang instances from package
5f61044 
Followup from work in secure-systems-lab#544 and secure-systems-lab#498
Other instances are in diff files, actual generated python code,
or unrelated to python shebang instances
@ckilcoin ckilcoin mentioned this issue Mar 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove shebang line from hash.py #498 ckilcoin/securesystemslib
1 participant
@lukpueh