Fix dependency monitoring and revise requirements files #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyUp GitHub integration for sslib has stopped working a while ago. Instead of troubleshooting, I'm seizing the opportunity to replace it with Dependabot, which has shown to work well in the in-toto org.
|
Looks like this also fixes coveralls issues (#207). Maybe due to the removal of the |
- New/updated requirements files: - requirements.txt: lists all unpinned immedeate runtime requirements (i.e. combines 'install_requires' and 'extras_require' from setup.py) and has instructions on how to create requirements-pinned.txt - requirements-pinned.txt: lists all pinned immedeate and transitive runtime requirements, based on requirements.txt, including environment markers, and is subjected to automatic updates with dependabot - requirements-min.txt: subset of requirements.txt without 'extras_require' (was purepy-requirements.txt). The requirements are not pinned, but updates should still trigger tests, if dependabot changes requirements-pinned.txt, which lists the same dependabots. - requirements-test.txt unpinned test runtime dependencies and test tooling. pinning is not so important there, because the end-user usually doesn't care about those dependencies. Also removes an obsolete version constraint on coverage. - requirements-dev.txt combines other requirements plus additional tooling and an editable install of securesystemslib - Use requirements-`<suffix>`.txt notation instead of `<prefix>`-requirements.txt to group them in file tree view. - Adopt changes in MANIFEST.in and tox.ini Co-Authored-By: Joshua Lock <jlock@vmware.com>
lukpueh
force-pushed
the
revise-requirements
branch
from
5129427
to
1a10ebf
Compare
|
Many thanks, @joshuagl! I squashed in your change, and also mentioned the removal of the version constraint in the commit message. |
This was referenced Feb 19, 2020
Merged
3 tasks
lukpueh
added a commit
to lukpueh/in-toto
that referenced
this pull request
Dec 11, 2020
Adopt docs for updating requirements-pinned.txt from based on their revision in tuf and sslib: - theupdateframework/python-tuf#982 - secure-systems-lab/securesystemslib#209 The update includes a transfer of the doc header + script/commands from requirements-pinned.txt to requirements.txt, and a thus resulting simplification of the commands. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
lukpueh
added a commit
to lukpueh/in-toto
that referenced
this pull request
Dec 11, 2020
Adopt docs for updating requirements-pinned.txt from based on their revision in tuf and sslib: - theupdateframework/python-tuf#982 - secure-systems-lab/securesystemslib#209 The update includes a transfer of the doc header + script/commands from requirements-pinned.txt to requirements.txt, and a thus resulting simplification of the commands. Signed-off-by: Lukas Puehringer <lukas.puehringer@nyu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Fixes #182
Similar changes in theupdateframework/python-tuf#982 and in-toto/in-toto#294
Description of the changes being introduced by the pull request:
Restructures and renames requirements files to remove redundancy and prepare for dependency monitoring with Dependabot.
Please see commit messages for details
Please verify and check that the pull request fulfils the following
requirements: