Add remove() method to StorageBackendInterface #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a remove method for removing/deleting items from the storage backend. The tuf reference implementation needs to be able to delete metadata files which have been marked as removed. Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/abstract-file-remove
branch
from
574aeda
to
d633b0b
Compare
Implement the new remove method of StorageBackendInterface in the FilesystemBackend with a simple os.remove() wrapper. Signed-off-by: Joshua Lock <jlock@vmware.com>
joshuagl
force-pushed
the
joshuagl/abstract-file-remove
branch
from
d633b0b
to
807a775
Compare
trishankatdatadog
approved these changes
May 12, 2020
|
Unfortunately I do not have write bit on this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #: N/A
Description of the changes being introduced by the pull request:
tuf needs to be able to delete files when tidying up outdated/revoked metadata, therefore our storage abstraction needs a method to remove files from storage.
remove()method tostorage.StorageBackendInterfaceremove()instorage.FilesystemBackendPlease verify and check that the pull request fulfils the following
requirements: