Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalise BBFarm + Light refactor #7

Merged
merged 25 commits into from
Jun 4, 2018
Merged

Generalise BBFarm + Light refactor #7

merged 25 commits into from
Jun 4, 2018

Conversation

XertroV
Copy link
Member

@XertroV XertroV commented May 31, 2018

  • generalise BBFarm so we can have more than one
  • give them a namespace
  • use 1st byte of extradata to indicate which BBFarm to use
  • add Iface for bbfarm
  • add BBFarmAux contract (using ABIEncoderV2 - shiny)
  • remove lots of getters from Index (they can be called directly)
  • remove some fwd functions from index
  • add IxLib so contracts have an easy way to access getters that have been removed
  • add submitProxyVote method to BBFarm to allow submitting someone elses vote (using ecrecover)
  • Maybe more?

XertroV added 11 commits May 30, 2018 23:51
@XertroV
Refactor bbFarms so we can have more than one.
46b6d5b 
Bonus: extraData now has a use!
@XertroV
refactor adding multiple bbfarms + arbitrary data
a6949f3 
- also, ix not building due to mismatch w interface
@XertroV
Refactor for multiple BBFarms + more
5820917 
- Reduce Ix size by moving getter functions out of Ix and into IxLib
- move arbitraryData to Backend

NOTE: Started using `pragma experimental ABIEncoderV2`. The reason
for this is returning bytes data en masse via BBFarm.

Some thoughts:
- We don't use any experimental features when doing anything where
  security is required (it's just for dumping votes out)
- Experimental features aren't good to use in production, but is there
  any risk using them just for retriving data?
- Maybe better to move these functions to a new contract so it's
  isolated as much as possible
@XertroV
add BBFarmAux, BBFarmIface, IxLib, BytesLib
8c4f740
@XertroV
Change ballotIds to use last 48 bits (instead of 40) for raw ids
9ae3937
@XertroV
Use BBFarmIface everywhere
a4b9bcf
@XertroV
ix tests pass
429ad2e
@XertroV
fix bb tests - note problem with ABIEncoderV2 in getVotes test
03c3d7f
@XertroV
Remove BBFarmAux from solcover (experimental breaks it)
b2c8c91
@XertroV
Add BBFarmProxy back in b/c tests rely on it
51c2fd4
@XertroV
Need to add BBFarmProxy back to bbtests
1450206
@coveralls
Copy link

coveralls commented May 31, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 162

  • 134 of 134 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 99.879%
Totals Coverage Status
Change from base Build 130: -0.1%
Covered Lines: 644
Relevant Lines: 644
💛 - Coveralls

@XertroV XertroV merged commit fefdead into master Jun 4, 2018
@XertroV XertroV deleted the f/signedBallots branch June 4, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@XertroV @coveralls