Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Maintenance: remove Jest/npm/node Versions from Makefiles #1607

Closed
Weltraumschaf opened this issue Feb 22, 2023 · 0 comments · Fixed by #1789
Closed

🔧 Maintenance: remove Jest/npm/node Versions from Makefiles #1607

Weltraumschaf opened this issue Feb 22, 2023 · 0 comments · Fixed by #1789
Assignees
@Ilyesbdlala
Labels
ci Changes to the continuous integration setup
Milestone
v4.1.0

Comments

@Weltraumschaf
Copy link
Member

Weltraumschaf commented Feb 22, 2023 •
edited

We have versions for Jest/npm/node in Makefiles/CI-YAMLs. This is error prone.

  • Can we simply use npm build ... to execute the tests with Jest verison from package.json?
  • Can we use nvm instead of versions in Env-Vars?
@Weltraumschaf Weltraumschaf added the ci Changes to the continuous integration setup label Feb 22, 2023
@rseedorff rseedorff changed the title Remove Jest/npm/node Versions from Makefiles 🔧 Maintenance: remove Jest/npm/node Versions from Makefiles Mar 7, 2023
@rseedorff rseedorff added this to the v4.1.0 milestone Mar 27, 2023
@Ilyesbdlala Ilyesbdlala self-assigned this Jun 30, 2023
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Added test:unit && test:integration jest targets
ee6f701 
this allows running npm run test:unit or npm test:integration in the makefiles instead of npx
giving the specific jest version is no longer required. package.json is instead used

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Changed Makefiles to now use npm run instead of npx
b7e6ebb 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Undo a change made for debugging purposes
d71a1bb 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Added missing jest dev dependency to autodiscovery pull secret…
527a5c2 
… extractor

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Added missing test:unit and test:integration scripts to test-scan
601d350 
i.e ~/tests/integration/package.json
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Ilyesbdlala added a commit that referenced this issue Jul 4, 2023
@Ilyesbdlala
#1607 Added missing test:unit and test:integration scripts to cascad…
35df216 
…ing-scan hook

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala mentioned this issue Jul 4, 2023
Merged
4 tasks
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Added test:unit && test:integration jest targets
816cd7b 
this allows running npm run test:unit or npm test:integration in the makefiles instead of npx
giving the specific jest version is no longer required. package.json is instead used

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Changed Makefiles to now use npm run instead of npx
e0e7a1a 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Undo a change made for debugging purposes
2c0fb25 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Added missing jest dev dependency to autodiscovery pull secret…
68ee7a5 
… extractor

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Added missing test:unit and test:integration scripts to test-scan
e81d788 
i.e ~/tests/integration/package.json
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
J12934 pushed a commit that referenced this issue Jul 10, 2023
@Ilyesbdlala @J12934
#1607 Added missing test:unit and test:integration scripts to cascad…
7de32f4 
…ing-scan hook

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ilyesbdlala Ilyesbdlala

Labels
ci Changes to the continuous integration setup
Projects
secureCodeBox v4
Archived in project
Milestone
v4.1.0
Development

Successfully merging a pull request may close this issue.

Removed Jest/npm/node Versions from Makefiles secureCodeBox/secureCodeBox
3 participants
@Weltraumschaf @rseedorff @Ilyesbdlala