Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes test dependencies installation for hooks locally #1219

Merged
merged 3 commits into from
Jun 15, 2022
Merged

Fixes test dependencies installation for hooks locally #1219

merged 3 commits into from
Jun 15, 2022

Conversation

Ilyesbdlala
Copy link
Member

@Ilyesbdlala Ilyesbdlala commented Jun 15, 2022 •
edited

Description

closes #1218

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

@Ilyesbdlala
Added path of test helpers dir to env paths file
5a42568 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Added step to install dependencies from tests/integration
c435f03 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Removed no longer necessary ci step to install npm dependecies from t…
eb06233 
…ests/integrations

No longer necessary because it's done in the "integration-tests" hook make target

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala self-assigned this Jun 15, 2022
@Ilyesbdlala Ilyesbdlala added the bug Bugs label Jun 15, 2022
@Ilyesbdlala Ilyesbdlala added this to Backlog in secureCodeBox v3 via automation Jun 15, 2022
@Ilyesbdlala Ilyesbdlala moved this from Backlog to In progress in secureCodeBox v3 Jun 15, 2022
secureCodeBox v3 automation moved this from In progress to Reviewer approved Jun 15, 2022
@the-simmon the-simmon merged commit 1ed766a into secureCodeBox:main Jun 15, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Jun 15, 2022
@Ilyesbdlala Ilyesbdlala deleted the bugfix/fix-test-deps-install branch June 22, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-simmon the-simmon the-simmon approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels
bug Bugs
Projects
No open projects
secureCodeBox v3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Makefiles do not install test deps completely
2 participants
@Ilyesbdlala @the-simmon