Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rocket.chat Notification Hook #1220

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Add rocket.chat Notification Hook #1220

merged 7 commits into from
Jun 23, 2022

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Jun 15, 2022

Description

This PR adds a new hook to post scan results to rocket.chat, more details in the update readme.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
…n the hooks isn't working as expected

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
`attributes` isn't a Map but an object as JSON.parse doesn't return maps

Also correct issue in trello hook related to this type error

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 added the enhancement New feature or request label Jun 15, 2022
@J12934 J12934 self-assigned this Jun 15, 2022
@J12934 J12934 added this to Backlog in secureCodeBox v3 via automation Jun 15, 2022
@J12934 J12934 moved this from Backlog to To Review in secureCodeBox v3 Jun 15, 2022
@github-actions
Copy link

github-actions bot commented Jun 15, 2022

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 1 0 0.22s
✅ DOCKERFILE dockerfilelint 1 0 0.39s
⚠️ DOCKERFILE hadolint 1 1 0.07s
✅ GIT git_diff yes no 0.15s
⚠️ JAVASCRIPT eslint 1 1 0.53s
✅ JSON eslint-plugin-jsonc 2 0 1.12s
✅ JSON jsonlint 2 0 0.55s
⚠️ JSON prettier 2 1 0.7s
✅ JSON v8r 2 0 4.68s
✅ SPELL misspell 16 0 0.04s
⚠️ TYPESCRIPT eslint 8 1 0.33s
⚠️ YAML prettier 4 1 0.7s
⚠️ YAML v8r 4 1 3.96s
⚠️ YAML yamllint 4 1 0.28s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Ilyesbdlala
Ilyesbdlala previously approved these changes Jun 22, 2022
Copy link
Member

@Ilyesbdlala Ilyesbdlala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems to be working correctly.
image

secureCodeBox v3 automation moved this from To Review to Reviewer approved Jun 22, 2022
…ions

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
secureCodeBox v3 automation moved this from Reviewer approved to To Review Jun 23, 2022
Copy link
Member

@Ilyesbdlala Ilyesbdlala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channel option also works.

secureCodeBox v3 automation moved this from To Review to Reviewer approved Jun 23, 2022
@J12934 J12934 merged commit cbbcd50 into main Jun 23, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Jun 23, 2022
@J12934 J12934 deleted the feature/rocket-chat branch June 23, 2022 09:08
@J12934 J12934 moved this from Done to counter in secureCodeBox v3 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants