Update defectdojo hook to jdk 17 #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
the-simmon
added
persistence
the-simmon
changed the title
SebieF
previously requested changes
Jun 21, 2022
|
|
||
| .PHONY: integration-tests | ||
| integration-tests: ## 🩺 Start integration test for this module in the namespace "integration-tests" | ||
| @echo "No integration tests for $(hook) defined!" |
There was a problem hiding this comment.
No newline at the end of the file
J12934
reviewed
Jun 21, 2022
| @@ -2,7 +2,7 @@ | |||
| # | |||
| # SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| FROM gradle:jdk11 as build | |||
| FROM gradle:jdk17 as build | |||
| COPY . /home/gradle/src | |||
| WORKDIR /home/gradle/src | |||
| RUN ./gradlew build -x test | |||
There was a problem hiding this comment.
Can you also update the distroless image to java 17? 🙏
There was a problem hiding this comment.
(Relevant code is in line 10, github didn't let me comment there) :)
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
Signed-off-by: Simon Hülkenberg <simon.huelkenberg@iteratec.com>
J12934
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Defectdojo hook to JDK 17. Closes #1054
First I updated the Gradle Version we use to the newest because the version we use currently does not support JDK 17. Doing this I got an error regarding lombok about some unexported modules.
java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x2c90820d) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x2c90820dI updated lombok to the newest version and it fixed the error. (I guess the old lombok version used some deprecated apis).
Another error occurred:
Entry META-INF/LICENSE is a duplicate but no duplicate handling strategy has been set. I used this solution from Stackoverflow:duplicatesStrategy = DuplicatesStrategy.EXCLUDEin build.gradle.Maybe there is a different solution but for now it works.
After this the build works. The unit test succeed and I also tested the hook locally and it successfully uploaded findings into a local Defectdojo instance.
Additionally I noticed that there are no integration tests defined (so no hook.test.js file is presented). Running
make testwhich will runmake integration-testshas weird behavior then. Jest will run the integration tests of all hooks which fails. I overwrote theìntegration-teststarget to stop this behavior. Nowmake testonly runs the correct hook tests for the defectdojo hook.