Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect mapping for SSLyze in DefectDojo Hook #1248

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Fix incorrect mapping for SSLyze in DefectDojo Hook #1248

merged 1 commit into from
Jun 28, 2022

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Jun 27, 2022

Closes #1246

@J12934 J12934 added the bug Bugs label Jun 27, 2022
@J12934 J12934 added this to Backlog in secureCodeBox v3 via automation Jun 27, 2022
@J12934 J12934 self-assigned this Jun 27, 2022
@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ GIT git_diff yes no 0.19s
✅ GROOVY npm-groovy-lint 1 0 7.71s
⚠️ JAVA checkstyle 1 1 2.29s
✅ SPELL misspell 2 0 0.08s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@J12934
Fix incorrect mapping for SSLyze in DefectDojo Hook
243bd3f 
Closes #1246

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
@J12934 J12934 force-pushed the fix/incorrect-defectdojo-scan-type branch from 0978736 to 243bd3f Compare June 27, 2022 09:37
@J12934
Copy link
Member Author

J12934 commented Jun 27, 2022

This initally broke in the DefectDojo 2.6 -> 2.7 Update, see: https://github.com/DefectDojo/django-DefectDojo/blob/612a0f682ae0a4e007196de4f438782464b3ae3d/docs/content/en/getting_started/upgrading.md#upgrading-to-defectdojo-version-27x

secureCodeBox v3 automation moved this from Backlog to Reviewer approved Jun 28, 2022
@J12934 J12934 merged commit 2b5c905 into main Jun 28, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Jun 28, 2022
@J12934 J12934 deleted the fix/incorrect-defectdojo-scan-type branch June 28, 2022 11:14
@J12934 J12934 moved this from Done to counter in secureCodeBox v3 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebieF SebieF SebieF approved these changes

Assignees

@J12934 J12934

Labels
bug Bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not find test type 'SSLyze 3 Scan (JSON)' in DefectDojo API.
2 participants
@J12934 @SebieF