Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated userId attribute #1861

Merged
merged 8 commits into from Aug 21, 2023
Merged

Remove deprecated userId attribute #1861

merged 8 commits into from Aug 21, 2023

Conversation

Zero3141
Copy link
Contributor

Description

  • Fixes #51: remove the deprecated userId attribute from the configuration
  • Bump version to release 1.0.0

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure that all your commits are signed-off and that you are added to the Contributors file.
  • Make sure that all CI finish successfully.
  • Optional (but appreciated): Make sure that all commits are Verified.

Heiko Kiesel added 4 commits August 11, 2023 10:14
Remove deprecated userId
48d4fba 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Adjust tests to work independently of Config class
6162a9a 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Refactoring
a121809 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
Bump defectdojo-client version from 1.0.0-SNAPSHOT to 1.0.0
2cd8c94 
Signed-off-by: Heiko Kiesel <heiko.kiesel@iteratec.com>
@Zero3141 Zero3141 added the enhancement New feature or request label Aug 11, 2023
@Zero3141 Zero3141 self-assigned this Aug 11, 2023
Weltraumschaf
Weltraumschaf requested changes Aug 11, 2023
View reviewed changes
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment.

...hook/src/main/java/io/securecodebox/persistence/strategies/VersionedEngagementsStrategy.java Show resolved Hide resolved
@Weltraumschaf Weltraumschaf enabled auto-merge (rebase) August 11, 2023 15:43
@Weltraumschaf Weltraumschaf merged commit 6e00609 into secureCodeBox:main Aug 21, 2023
40 checks passed
@Zero3141 Zero3141 deleted the enhancement/remove-deprecated branch August 23, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Weltraumschaf Weltraumschaf Weltraumschaf approved these changes

Assignees

@Zero3141 Zero3141

Labels
enhancement New feature or request
Projects
secureCodeBox v4
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Deprecated API from Config
2 participants
@Zero3141 @Weltraumschaf