Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Email Notifier and Email Template To Notification Hook #386

Merged
merged 16 commits into from
May 5, 2021
Merged

Added Email Notifier and Email Template To Notification Hook #386

merged 16 commits into from
May 5, 2021

Conversation

fuhrmeistery
Copy link
Member

  • Add Implementation For Email Notifier
  • Add Basic Email Template
  • Add Basic Test For Email Notifier

@fuhrmeistery fuhrmeistery force-pushed the feature/email-notifier branch 2 times, most recently from 8e1bdda to 7813948 Compare April 21, 2021 11:13
This was linked to issues Apr 23, 2021
⚓️ Add a generic notification Hook with message templates #318
Closed
Implement a Email Notification Hook #311
Closed
@fuhrmeistery fuhrmeistery marked this pull request as ready for review April 26, 2021 07:44
@fuhrmeistery fuhrmeistery marked this pull request as draft April 27, 2021 13:59
@fuhrmeistery fuhrmeistery requested a review from J12934 May 3, 2021 08:44
@fuhrmeistery fuhrmeistery marked this pull request as ready for review May 3, 2021 08:44
@rseedorff rseedorff added the enhancement New feature or request label May 4, 2021
@rseedorff rseedorff added this to In Progress in secureCodeBox v2 via automation May 4, 2021
@rseedorff rseedorff added this to the v2.7.0 milestone May 4, 2021
secureCodeBox v2 automation moved this from In Progress to To Review May 4, 2021
rseedorff
rseedorff requested changes May 4, 2021
View reviewed changes
Copy link
Member

@rseedorff rseedorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions and minor improvements...

@fuhrmeistery
Add Nodemailer
ad7b957 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Add Implementation For Email Notifier
653ffa4 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Minor Refactoring
03bafa7 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Add Basic Test For Email Notifier
7692fb2 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Update Documentation For Email Notifier
193e35b 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Remove Unused Constant
1b463d5 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
fuhrmeistery and others added 9 commits May 4, 2021 19:57
@fuhrmeistery
Make Defaults More Clear
d47b5f7 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Fix Typo And Spacing
d01b655 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Fix Spelling
66ef6eb 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Use Connection URL Instead of Connection Object
fc507c2 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery
Update README For Changed SMTP Configuration
8b32108 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@iteratec.com>
@fuhrmeistery @rseedorff
Update hooks/notification-hook/README.md
14ffd06 
Co-authored-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@fuhrmeistery
Updating Helm Docs
f9eabaa
@fuhrmeistery
Remove Demo Credentials
13432dd 
Signed-off-by: Yannik Fuhrmeister <yannik.fuhrmeister@protonmail.com>
@fuhrmeistery @actions-user
Updating Helm Docs
8e53308
@rseedorff rseedorff merged commit 62da8e2 into secureCodeBox:main May 5, 2021
secureCodeBox v2 automation moved this from To Review to Done May 5, 2021
@fuhrmeistery fuhrmeistery deleted the feature/email-notifier branch May 6, 2021 07:15
@rseedorff rseedorff changed the title Add Email Notifier To Notification Hook Added Email Notifier and Email Template To Notification Hook May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rseedorff rseedorff rseedorff approved these changes

@J12934 J12934 Awaiting requested review from J12934

Assignees

@fuhrmeistery fuhrmeistery

Labels
enhancement New feature or request
Projects
No open projects
secureCodeBox v2
Done
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.

⚓️ Add a generic notification Hook with message templates Implement a Email Notification Hook
3 participants
@fuhrmeistery @rseedorff @J12934