Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted ADRs to Markdown #397

Merged
merged 3 commits into from
May 5, 2021
Merged

Converted ADRs to Markdown #397

merged 3 commits into from
May 5, 2021

Conversation

Weltraumschaf
Copy link
Member

@Weltraumschaf Weltraumschaf commented May 3, 2021

We convert the ADRs to Markdown so we can include them into our doc project.

@Weltraumschaf Weltraumschaf self-assigned this May 4, 2021
@Weltraumschaf Weltraumschaf added architecture Architecture changes documentation Improvements or additions to documentation and removed architecture Architecture changes labels May 4, 2021
@Weltraumschaf Weltraumschaf added this to In Progress in secureCodeBox v2 via automation May 4, 2021
@Weltraumschaf Weltraumschaf changed the title Fix table syntax in ADR-0004 Convert ADRs to Markdown May 4, 2021
@Weltraumschaf Weltraumschaf marked this pull request as draft May 4, 2021 11:18
The supersedes had an errornous | which resulted in bad rendered
table. I used parens for the supersed marker.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
We want to use the ADRs in our documentation project, but this
does not support Asciidoc. So we decided to convert them.

Initial convertion is done w/ Pandoc:

```
for i in {0..7}; do \
  asciidoc -b docbook "adr_000${i}.adoc" \
  pandoc -f docbook -t markdown_strict "adr_000${i}.xml" -o "adr_000${i}.md" \
  rm "adr_000${i}.xml" \
done
```

There were some syntax errors afterwards which were fixed manually.

The linebreaks of paragraphs were removed consequntly because we use
linewrap in the editors.

Signed-off-by: Sven Strittmatter <sven.strittmatter@iteratec.com>
@Weltraumschaf Weltraumschaf marked this pull request as ready for review May 4, 2021 15:12
@rseedorff rseedorff enabled auto-merge May 4, 2021 15:23
@rseedorff rseedorff added this to the v2.7.0 milestone May 4, 2021
@Weltraumschaf Weltraumschaf removed the request for review from fuhrmeistery May 5, 2021 09:03
@Weltraumschaf Weltraumschaf merged commit d6f7520 into secureCodeBox:main May 5, 2021
secureCodeBox v2 automation moved this from In Progress to Done May 5, 2021
@Weltraumschaf Weltraumschaf moved this from Done to counter in secureCodeBox v2 May 7, 2021
@Weltraumschaf Weltraumschaf deleted the fix-adr4 branch May 11, 2021 15:59
@rseedorff rseedorff changed the title Convert ADRs to Markdown Converted ADRs to Markdown May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants