Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Helm docs commits #421

Merged
merged 7 commits into from
May 12, 2021
Merged

Sign Helm docs commits #421

merged 7 commits into from
May 12, 2021

Conversation

twwd
Copy link
Contributor

@twwd twwd commented May 11, 2021

Description

Extends the GitHub workflow to sign the commits that are generated during updating Helm docs. Uses https://github.com/norwoodj/helm-docs

Additionally, fixes a bunch of typos and grammar errors to trigger the doc re-generation.

Closes #296

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@twwd twwd changed the title Sign helm docs commits Sign Helm docs commits May 11, 2021
@twwd twwd added documentation Improvements or additions to documentation enhancement New feature or request and removed documentation Improvements or additions to documentation labels May 11, 2021
@twwd twwd marked this pull request as ready for review May 11, 2021 14:43
@twwd twwd requested a review from J12934 May 12, 2021 09:57
@twwd twwd added this to To Review in secureCodeBox v2 May 12, 2021
@fuhrmeistery fuhrmeistery merged commit f7af2ea into main May 12, 2021
secureCodeBox v2 automation moved this from To Review to Done May 12, 2021
@fuhrmeistery fuhrmeistery deleted the sign-helm-docs-commits branch May 12, 2021 11:45
@rseedorff rseedorff added ci Changes to the continuous integration setup and removed enhancement New feature or request labels May 12, 2021
@rseedorff rseedorff added this to the v2.7.0 milestone May 12, 2021
@twwd twwd moved this from Done to counter in secureCodeBox v2 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to the continuous integration setup maintenance
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

🤖 Automatic Helm Doc Comits are not signed
3 participants