Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans #430

Merged
merged 12 commits into from
May 23, 2021
Merged

🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans #430

merged 12 commits into from
May 23, 2021

Conversation

EndPositive
Copy link
Contributor

@EndPositive EndPositive commented May 18, 2021 •
edited by rseedorff

Description

This PR implements some of the features described in #334 related to annotations and labels in cascading scans.

close #334

Todo

  • Update DSSH code to handle cascades.inheritLabels and cascades.inheritAnnotations
  • Introduce CascadingRule.spec.scanLabels and CascadingRule.spec.scanAnnotations.
  • Add templating to CascadingRule.spec.scanLabels and CascadingRule.spec.scanAnnotations.
  • Update CRD's & types in other scanners/hooks.
  • Update docs: #78

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@rseedorff rseedorff added the hook Implement or update a hook label May 18, 2021
@rseedorff rseedorff added this to In Progress in secureCodeBox v2 via automation May 18, 2021
@rseedorff rseedorff linked an issue May 18, 2021 that may be closed by this pull request
🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans #334
Closed
@rseedorff rseedorff added the defectdojo All issues regarding the DefectDojo Integration label May 19, 2021
@rseedorff
Copy link
Member

Hi @EndPositive,
thx for you help implementing this issue 👍🏻
If you have any questions drop us a line via Slack or in this issue 😊

@EndPositive
Copy link
Contributor Author

Hey @rseedorff , no problemo! I'm planning to get it ready for review by tomorrow. If I have any more questions, I'll be sure to reach out!

@EndPositive EndPositive marked this pull request as ready for review May 21, 2021 09:33
@EndPositive EndPositive mentioned this pull request May 21, 2021
Merged
@rseedorff rseedorff requested a review from J12934 May 21, 2021 10:02
rseedorff
rseedorff requested changes May 23, 2021
View reviewed changes
Copy link
Member

@rseedorff rseedorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @EndPositive,
your PR looks great 👍🏻 To prevent a breaking change the scanAnnotations shouldn't be required.

secureCodeBox v2 automation moved this from In Progress to To Review May 23, 2021
@EndPositive @rseedorff
Apply suggestions from code review
5eb1a07 
Co-authored-by: Robert Seedorff <Robert.Seedorff@iteratec.com>
@EndPositive
Copy link
Contributor Author

Good catch, thanks!

@rseedorff rseedorff merged commit 1211070 into secureCodeBox:main May 23, 2021
secureCodeBox v2 automation moved this from To Review to Done May 23, 2021
@EndPositive EndPositive deleted the cascading_scans_custom_annotations branch June 3, 2021 14:33
@J12934 J12934 moved this from Done to counter in secureCodeBox v2 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rseedorff rseedorff rseedorff approved these changes

@J12934 J12934 Awaiting requested review from J12934

Assignees
No one assigned
Labels
defectdojo All issues regarding the DefectDojo Integration hook Implement or update a hook
Projects
No open projects
secureCodeBox v2
counter
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🕸 Extend the Cascading-Scans Hook to generate custom labels or annotations for subsequent scans
2 participants
@EndPositive @rseedorff