Skip to content

Conversation

twwd
Copy link
Contributor

@twwd twwd commented Aug 12, 2021

Updates NPM dependencies to the latest compatible versions including
version 6.1.8 of tar that contains security fixes.

In addition, fixes that npm 6 was used instead of npm 7 in unit tests and an outdated command to transpile TypeScript.

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Updates NPM dependencies to the latest compatible versions including
version 6.1.8 of `tar` that contains security fixes.

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
@twwd twwd added the dependencies Pull requests that update a dependency file label Aug 12, 2021
@twwd twwd marked this pull request as draft August 12, 2021 06:04
twwd added 3 commits August 12, 2021 09:55
Installs the required Node.js and NPM versions also for unit tests.

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Removes copy & paste remaining that tries to call the typescript
 transpiler on non-existing files.

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
Uses `tsc` instead of `typescript` to transpile the `hook.ts`
as suggested here: https://www.typescriptlang.org/download

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
@twwd twwd force-pushed the maintenance/update-npm-deps branch from 23fe136 to 2735ea3 Compare August 12, 2021 07:55
Installs the parser-sdk NPM dependencies for unit tests to prevent
`Cannot find module 'ajv-draft-04'` error.

Signed-off-by: Tim Walter <tim.walter@iteratec.com>
@twwd twwd added the bug Bugs label Aug 12, 2021
@twwd twwd marked this pull request as ready for review August 12, 2021 08:06
@twwd twwd requested a review from J12934 August 12, 2021 08:06
@J12934 J12934 enabled auto-merge August 12, 2021 08:08
@J12934 J12934 merged commit 4943ed0 into main Aug 12, 2021
@J12934 J12934 deleted the maintenance/update-npm-deps branch August 12, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants