-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixed scanner parseDefinitions ttlSecondsAfterFinished HelmValue inconsistencies #616
Conversation
No pun intended Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Replacing ttlSecondsAfterFinished: {{ .Values.parser.ttlSecondsAfterFinished }} with ttlSecondsAfterFinished: {{ .Values.parser.image.ttlSecondsAfterFinished }} Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
+1 for consistency. But placing the ttl after finished would be conceptually wrong for me, as the ttl has nothing to do with the image, but the kubernetes job created by the parseDefinitions. I think it is fine where it it. |
Replacing ttlSecondsAfterFinished: {{ .Values.parser.image.ttlSecondsAfterFinished }} with ttlSecondsAfterFinished: {{ .Values.parser.ttlSecondsAfterFinished }} Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
Fair point, wasn't sure about that. In hindsight, I think only ncrack used this .image. so it makes more sense to adjust that. |
Because of failing ci pipeline integration tests Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
This reverts commit 2371720. Signed-off-by: Sebastian <sebastian.franz@iteratec.com>
0f766ec
to
b5b16d6
Compare
Description
We had a lot of new scanner pull requests recently, that's why I came to think about code/file consistency for our scanners. I think it is worth discussing this topic publicly or in our retro, because it makes our code more maintainable and easier to understand.
For now, I only fixed some small inconsistencies and a typo for templates/scanner-name-parse-definition.yaml.