Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Typo3 demo-target #632

Merged
merged 10 commits into from
Sep 10, 2021
Merged

Added a Typo3 demo-target #632

merged 10 commits into from
Sep 10, 2021

Conversation

Ilyesbdlala
Copy link
Member

Description

This PR adds a Typo3 demo-target. A Dockerfile and a corresponding Helm chart are included.
This allows running cascading scans and integration tests with the Typo3scan scanner.
The demo-target Image has to be uploaded to the secureCodeBox docker hub before merging this to the main branch.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Ilyesbdlala and others added 8 commits September 6, 2021 17:46
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Installation Files are copied to the Docker image to bypass 'Setup'

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done so that it complies with the other demo-targets

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Also added the files that will be copied to the image.

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
This is done to fix the CI pipeline
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added the testing Improvements or additions regarding the test setup label Sep 8, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Sep 8, 2021
@Ilyesbdlala Ilyesbdlala added this to In progress in secureCodeBox v3 via automation Sep 8, 2021
@Ilyesbdlala Ilyesbdlala linked an issue Sep 8, 2021 that may be closed by this pull request
3 tasks
@Ilyesbdlala Ilyesbdlala moved this from In progress to To Review in secureCodeBox v3 Sep 8, 2021
Ilyesbdlala and others added 2 commits September 9, 2021 13:26
Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>

Co-authored-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Copy link
Member

@J12934 J12934 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build and pushed the image to docker.io/securecodebox/old-typo3:v9.5.26:

https://hub.docker.com/repository/docker/securecodebox/old-typo3

secureCodeBox v3 automation moved this from To Review to Reviewer approved Sep 10, 2021
@J12934 J12934 merged commit 2d2c6ee into main Sep 10, 2021
secureCodeBox v3 automation moved this from Reviewer approved to Done Sep 10, 2021
@J12934 J12934 deleted the feature/add-typo3-demo-target branch September 10, 2021 12:20
@Ilyesbdlala Ilyesbdlala moved this from Done to counter in secureCodeBox v3 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Improvements or additions regarding the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Vulnerable / Outdated Typo3 Demo Target
2 participants