Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade all npm packages with npm audit fix #635

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Upgrade all npm packages with npm audit fix #635

merged 1 commit into from
Sep 10, 2021

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Sep 10, 2021

Upgraded all npm dependencies, with our ./bin/npm-audit-fix-all.sh script.
This should replace the open snyk prs.

Closes #626
Closes #627
Closes #628
Closes #629
Closes #631

@J12934 J12934 added dependencies Pull requests that update a dependency file maintenance labels Sep 10, 2021
@J12934 J12934 added this to In progress in secureCodeBox v3 via automation Sep 10, 2021
secureCodeBox v3 automation moved this from In progress to Reviewer approved Sep 10, 2021
SebieF
SebieF previously approved these changes Sep 10, 2021
Copy link
Contributor

@SebieF SebieF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be a bit odd that the package.json are now oneliners, but could also be the display on GitHub?

@J12934
Copy link
Member Author

J12934 commented Sep 10, 2021

Mh that't weird, I'll take a look on why that is happening...

@J12934 J12934 marked this pull request as draft September 10, 2021 10:20
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
secureCodeBox v3 automation moved this from Reviewer approved to To Review Sep 10, 2021
@J12934
Copy link
Member Author

J12934 commented Sep 10, 2021

Ok should be correct now, seems like npm was only doing it for package-json where it found the formatting to be weird.

Still kind of a weird behavior of npm...

@J12934 J12934 marked this pull request as ready for review September 10, 2021 11:33
@J12934 J12934 requested a review from SebieF September 10, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants