Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to Typo3Scan #647

Merged
merged 8 commits into from
Sep 17, 2021
Merged

Add integration tests to Typo3Scan #647

merged 8 commits into from
Sep 17, 2021

Conversation

Ilyesbdlala
Copy link
Member

Description

This PR uses the new old-typo3 demo-target to implement Integration tests for the Typo3Scan Scanner in The CI.
The demo-target old-typo3 is also built within the CI.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@Ilyesbdlala
Added draft typo3scan integration test
003ff2e 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Addded the typo3scan test to the ci.yaml
589a02c 
The demo-target build is also added

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
The old-typo3 image now runs under root user
e2c780b 
This is to allow binding to port 80 from kind cluster

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Fixed typo3scan integration test parameters
d4efb0b 
Updated Test Snapshot

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Added a test to typo3scan.test.js
e60972a 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Added typo3scan to third-party scanner builds
3728bb3 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Merge branch 'main' into feature/add-typo3-integration-test
00ccd29 
Resolved conflict .github/workflows/ci.yaml
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added scanner Implement or update a security scanner testing Improvements or additions regarding the test setup labels Sep 15, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Sep 15, 2021
@Ilyesbdlala Ilyesbdlala added this to In progress in secureCodeBox v3 via automation Sep 15, 2021
@Ilyesbdlala
Fixed wrong merge on ci.yaml
7ed25be 
And Better typo3scan test description

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala moved this from In progress to To Review in secureCodeBox v3 Sep 15, 2021
@Ilyesbdlala Ilyesbdlala mentioned this pull request Sep 15, 2021
Merged
3 tasks
secureCodeBox v3 automation moved this from To Review to Reviewer approved Sep 17, 2021
@J12934 J12934 merged commit d0e3e03 into main Sep 17, 2021
secureCodeBox v3 automation moved this from Reviewer approved to Done Sep 17, 2021
@J12934 J12934 deleted the feature/add-typo3-integration-test branch September 17, 2021 09:10
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels
scanner Implement or update a security scanner testing Improvements or additions regarding the test setup
Projects
No open projects
secureCodeBox v3
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ilyesbdlala @J12934