Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Improvements to SCB Bot #798

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Add Improvements to SCB Bot #798

merged 8 commits into from
Nov 15, 2021

Conversation

Ilyesbdlala
Copy link
Member

Description

Closes #795

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

@Ilyesbdlala
Move versionApi to annotations attribute in scb bot worklflow
900924c 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Add updating helm docs to the scb bot workflow
d65602f 
also added on-push trigger for testing

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala added maintenance testing Improvements or additions regarding the test setup labels Nov 9, 2021
@Ilyesbdlala Ilyesbdlala added this to the v3.4.0 milestone Nov 9, 2021
@Ilyesbdlala Ilyesbdlala self-assigned this Nov 9, 2021
@Ilyesbdlala Ilyesbdlala added this to In progress in secureCodeBox v3 via automation Nov 9, 2021
@Ilyesbdlala
Removed on-push trigger
df78b94 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala moved this from In progress to To Review in secureCodeBox v3 Nov 9, 2021
@Ilyesbdlala
Actually removing the on-push trigger
57ec1bf 
File was not saved

Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala
Added release changes to created PRs description
a45333c 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala moved this from To Review to In progress in secureCodeBox v3 Nov 9, 2021
@Ilyesbdlala
Remove on push trigger
0f78779 
Signed-off-by: Ilyes Ben Dlala <ilyes.bendlala@iteratec.com>
@Ilyesbdlala Ilyesbdlala moved this from In progress to To Review in secureCodeBox v3 Nov 9, 2021
secureCodeBox v3 automation moved this from To Review to Reviewer approved Nov 15, 2021
@J12934 J12934 merged commit b9cbb68 into main Nov 15, 2021
secureCodeBox v3 automation moved this from Reviewer approved to Done Nov 15, 2021
@J12934 J12934 deleted the feature/improve-scb-bot branch November 15, 2021 16:23
@snyk-bot snyk-bot mentioned this pull request Jul 19, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 9, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J12934 J12934 J12934 approved these changes

Assignees

@Ilyesbdlala Ilyesbdlala

Labels
maintenance testing Improvements or additions regarding the test setup
Projects
No open projects
secureCodeBox v3
  
Done
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Improvements to the SCB-Bot
2 participants
@Ilyesbdlala @J12934