Update ZAP, ZAP-Advanced, Nikto, and Screenshooter cascading rules to support non-standard HTTP(S) ports #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analogous to #920, this commit splits the cascading rule for ZAP into two: one for HTTP and one for HTTPS. This allows it to cover HTTP(S) services on nonstandard ports. This also requires adding the port as an extra parameter. Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
malexmave
added
enhancement
malexmave
changed the title
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
Signed-off-by: Max Maass <max.maass@iteratec.com>
malexmave
changed the title
J12934
approved these changes
Jan 10, 2022
This was referenced Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to #920, this commit splits the cascading rule for ZAP, ZAP-advanced, and Screenshooter into two: one for HTTP and one for HTTPS. This allows it to cover HTTP(S) services on nonstandard ports. This also requires adding the port as an extra parameter, which is also done in this change. Nikto already supported this, but now also matches on alternative HTTP ports that are called "http-*"
Also updates the integration test to work with the current version of ZAP plugins (started failing without any changes on our end).
Checklist
npm testruns for the whole project.