Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename example files for zap-advanced to avoid docusaurus error #933

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

RamiSouai
Copy link
Member

After updating Docusaurus to version 2.0.0-beta.14, an error is thrown during SSR if there are no TabItems with the default value. The Zap-Advanced docs page currently has no examples under "nginx" and "integration-tests" and therefore no tabs in the sections. A quick check in scanners/zap-advances/examples/nginx and integration-tests shows that the scan example file names deviate from the usual "scan.yaml" and thus aren't found during the docusaurus build, leading to this error:

image

Signed-off-by: Rami Souai rami.souai@iteratec.com

Description

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

Signed-off-by: Rami Souai <rami.souai@iteratec.com>
@RamiSouai RamiSouai self-assigned this Jan 17, 2022
@RamiSouai RamiSouai added the bug Bugs label Jan 17, 2022
@RamiSouai RamiSouai added this to Backlog in secureCodeBox v3 via automation Jan 17, 2022
@RamiSouai RamiSouai moved this from Backlog to To Review in secureCodeBox v3 Jan 17, 2022
Signed-off-by: Rami Souai <rami.souai@iteratec.com>
secureCodeBox v3 automation moved this from To Review to Reviewer approved Jan 17, 2022
@J12934 J12934 merged commit d46f64f into main Jan 17, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Jan 17, 2022
@J12934 J12934 deleted the bugfix/rename-zap-advanced-examples branch January 17, 2022 15:01
@RamiSouai RamiSouai restored the bugfix/rename-zap-advanced-examples branch January 17, 2022 15:24
@J12934 J12934 deleted the bugfix/rename-zap-advanced-examples branch May 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants