-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Email Reciever Field in Notification Hook #946
Conversation
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
This is the behaviour which is acutally documented and makes more sense for the email notification hook Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I have a small comment on a typo. Also, since you mentioned the documentation: It is currently a bit inconsistent. At the top, it says "The general configuration of a notification looks something like this" and then shows an example that loads the env from a secret. However, for the email hook, it then loads the env directly from the file, with the username and password for the email account visible. Maybe we can take this opportunity to also fix that small part of the docs? (Reworking the rest of the docs for the hook is tracked in https://github.com/secureCodeBox/documentation/issues/182 and does not need to be addressed in this PR.)
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
a2a1f19
to
98ccd8d
Compare
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Description
The Email Notifier of the Notification Hook currently behaves differently as described in the Docs.
The docs indicate that
channel.endPoint
is supposed to be email recipient for the notification but actually has to be the name of aenv
var which then contains the email address.This is a feature was added for the Slack & Microsoft Teams Notifier as these use webhook urls containing sensitive tokens.
I've updated the implementation to behave like the documentation.
Checklist
npm test
runs for the whole project.