Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in ZAP for Alerts without Instances #949

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Fix Error in ZAP for Alerts without Instances #949

merged 2 commits into from
Feb 4, 2022

Conversation

J12934
Copy link
Member

@J12934 J12934 commented Feb 1, 2022

Description

Encountered the following error in the ZAP parser when running a scan against BodgeIt:

Starting Parser
Fetching result file
Fetched result file
Parser failed with error:
TypeError: Cannot read property 'map' of undefined
    at createFindingFromAlert (/home/app/parser-wrapper/parser/parser.js:55:48)
    at parse (/home/app/parser-wrapper/parser/parser.js:96:23)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at async main (/home/app/parser-wrapper/parser-wrapper.js:126:16)

Update the test to test for this and updated the implementation.

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • Make sure npm test runs for the whole project.
  • Make codeclimate checks happy

J12934 and others added 2 commits February 1, 2022 16:56
…to it

Signed-off-by: Jannik Hollenbach <jannik.hollenbach@iteratec.com>
Signed-off-by: GitHub Actions <securecodebox@iteratec.com>
@J12934 J12934 added the bug Bugs label Feb 1, 2022
@J12934 J12934 self-assigned this Feb 1, 2022
@J12934 J12934 added this to Backlog in secureCodeBox v3 via automation Feb 1, 2022
secureCodeBox v3 automation moved this from Backlog to Reviewer approved Feb 1, 2022
@J12934 J12934 merged commit d5af06d into main Feb 4, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Feb 4, 2022
@J12934 J12934 deleted the fix/zap-fix branch February 4, 2022 09:12
@J12934 J12934 moved this from Done to counter in secureCodeBox v3 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants