Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SCB-Bot helm-docs version to 1.6.0 #955

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

malexmave
Copy link
Member

We updated helm-docs for the helm-docs CI job to 1.6.0, but did not do the same for the SCB-Bot, which may be the root cause of #953 (working theory, will have to be validated with the next PR opened by the Bot after this is merged).

Signed-off-by: Max Maass <max.maass@iteratec.com>
@malexmave malexmave self-assigned this Feb 4, 2022
@malexmave malexmave added this to Backlog in secureCodeBox v3 via automation Feb 4, 2022
@malexmave malexmave moved this from Backlog to To Review in secureCodeBox v3 Feb 4, 2022
Copy link
Member

@Weltraumschaf Weltraumschaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should extract this download and verify shell snippet into a shell script in bin/, so that we do not have this code duplication. Which obviously resulted in a bug^^

secureCodeBox v3 automation moved this from To Review to Reviewer approved Feb 4, 2022
@Weltraumschaf Weltraumschaf merged commit ce6dcc1 into main Feb 4, 2022
secureCodeBox v3 automation moved this from Reviewer approved to Done Feb 4, 2022
@Weltraumschaf Weltraumschaf deleted the bot/upgrade-helm-docs branch February 4, 2022 09:54
@Weltraumschaf Weltraumschaf moved this from Done to counter in secureCodeBox v3 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants