Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax / use for heading in sidebar #858

Open
ChrisXKeroack opened this issue Jun 30, 2023 · 1 comment
Open

Incorrect syntax / use for heading in sidebar #858

ChrisXKeroack opened this issue Jun 30, 2023 · 1 comment
Labels
accessibility Improving accessibility of framework good first issue Good for newcomers

Comments

@ChrisXKeroack
Copy link

Describe the bug
Sidebar uses a heading without declaring a heading level

To Reproduce
Steps to reproduce the behavior:

  1. https://openfl.readthedocs.io/en/latest/index.html
  2. Examine the code for the 'CONTENTS:' text

notice: Sidebar declares a heading for ‘contents’ via role=heading but doesn’t set a heading level

Expected behavior
add aria-heading="2"

Desktop:
This issue is not OS or browser specific, but for tracking purposes, testing was done on Win11, in Edge Version 114.0.1823.58 (Official build) (64-bit).

Smartphone:
This issue is not device, OS, or browser specific.

Additional context
This is an accessibility issue, please annotate this bug with the 'accessibility' label.

@fstrr
Copy link
Contributor

fstrr commented Jul 5, 2023

This is an issue with the Read The Docs platform.

Note: the ARIA 1.1 specification allowed the use of role=heading without an accompanying aria-level attribute, and would default to a heading level of 2 if aria-level was missing. The ARIA 1.2 specification forbids that and requires an aria-level attribute.

@psfoley psfoley added good first issue Good for newcomers accessibility Improving accessibility of framework labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improving accessibility of framework good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants